This series introduces a log_mask_ln! macro which is inspired by the C version
and is just a thin wrapper around qemu_log(). It caters to Rust expectations by
accepting an enum for logging categories and working like the format! macro. The
macro then gets used in the pl011 device which either had its logging commented
out or relied on eprintln!() which can't be silenced by users.

Testing done:
* Run `make clippy`
* Purposefully trigger warnings with varying number of arguments

v3:
* Add macro to prelude (Manos)
* Have log_mask_ln! rather than log_mask! macro (Manos, Paolo)
* rustdoc improvements (Paolo)
* Fix logged function names (Manos)
* Add missing logging to pl011 to match C version (Paolo)
* Add patch to make clippy happier (which still complains about "PrimeCell" in
  rustdoc comment)

v2:
* Drop the qemu_ prefix from the macro name (Paolo)
* Use an enum for the logging categories in PascalCase as suggested by Paolo

Bernhard Beschow (4):
  rust/qemu-api: Add initial logging support based on C API
  rust/hw/char/pl011/src/device: Implement logging
  rust/hw/char/pl011/src/device: Add missing logging to match C version
  rust/qemu-api: Fix clippy lint `missing_const_for_fn`

 docs/devel/rust.rst              |  1 +
 rust/wrapper.h                   |  2 +
 rust/hw/char/pl011/src/device.rs | 18 ++++++--
 rust/qemu-api/meson.build        |  1 +
 rust/qemu-api/src/cell.rs        |  2 +-
 rust/qemu-api/src/lib.rs         |  1 +
 rust/qemu-api/src/log.rs         | 78 ++++++++++++++++++++++++++++++++
 rust/qemu-api/src/prelude.rs     |  2 +
 rust/qemu-api/src/qom.rs         |  2 +-
 9 files changed, 101 insertions(+), 6 deletions(-)
 create mode 100644 rust/qemu-api/src/log.rs

-- 
2.49.0


Reply via email to